natcap / global-web-viewer

A web viewer prototype for visualizing and analyzing global data.
GNU General Public License v3.0
3 stars 1 forks source link

Fix layering bug #88

Closed dcdenu4 closed 3 years ago

dcdenu4 commented 3 years ago

This bug was brought about after testing sorting but wasn't necessarily caused by sorting. Basically the bug was not being able to reliably redraw the z-index order when changing scale, changing basemaps, and changing visibility. This commit is a first pass at fixing that. It currently seems to function as expected.

The big thing I was missing was in how map.moveLayer(layerId, beforeId) was behaving. I was moving the least visible layers first "before" more visible layers. However, those more "visible" layers could be anywhere in the layering order, causing unexpected behavior. Thus, moving / setting the most visible layers first provided a stable way to get expected layering order.