natcap / invest.users-guide

The User's Guide for InVEST
22 stars 17 forks source link

Update UG for trademark and NatCap branding #133

Closed phargogh closed 1 year ago

phargogh commented 1 year ago

Per a request from the comms team, this PR updates the partner logos and slightly updates a few styles and fonts in keeping with NatCap branding in addition to adding the ® in a few places.

There are a few functional things I wanted to point out as an FYI for the whole software team:

  1. Sphinx really doesn't do anything intelligent with images like logos, so I added a script to handle uniform scaling and padding. When we add a partner org, we should run the script on the logo they give us and commit the resulting image.
  2. The _templates directory now contains jinja overrides for our theme. Right now it's pretty simple (just adding fonts and related stylesheets) but could be extended as needed for future theme modifications. The Makefile now excludes dirs prefixed with _

Anyways, happy to discuss!

Here's a preview of changes:

Screenshot 2023-09-20 at 4 40 28 PM
dcdenu4 commented 1 year ago

@davemfish, I feel the same way and your comment made me chuckle. It's like those flashing ads: invest, InVEST, INVEST!!!

I know it's a pain to work in this framework, but I wouldn't mind seeing the logo in the upper left, removing the "InVEST" home button below, and is it possible to center the "InVEST User Guide" title?

davemfish commented 1 year ago

and is it possible to center the "InVEST User Guide" title?

This title is left-aligned with the body of text below, there's just a lot of space in between now with the logos. But on other pages, like a model chapter, it probably looks good with the left-alignment.

phargogh commented 1 year ago

Thanks for the comments @davemfish and @dcdenu4 !

Although the theme is supposed to be able to hide the brand name below the logo through an option in conf.py, that wasn't working for me. This is now controlled with some custom CSS. I also added some custom CSS to center-align the UG title, and confirmed that this change does not alter the alignment on other pages. Screenshots below as a demonstration.

Screenshot 2023-09-21 at 2 35 04 PM Screenshot 2023-09-21 at 2 35 35 PM
davemfish commented 1 year ago

Thanks for accommodating these nitpicky requests; looks great!