Open davemfish opened 1 year ago
This would be a very satisfying change. 👍
I think the cropname
one is because there's a standard set of crops that the model supports, and so it's letting you map your arbitrary LULC classification to that fixed crop classification
Just adding a +1 to this. For some reason, it's only today that I noticed that HQ uses "lulc", and was about to file an issue asking for it to be matched to the others that use "lucode", but @davemfish is already on it!
If a biophysical table is an invest input that has a row for each landcover type, then all tables need a landcover column. Most models call this column
lucode
, but some do not:lulc
code
lucode
tocrop_name
, and then the biophysical table (fertilization rate table) usescrop_name
. Probably there is a reason for this, so maybe it's okay not to touch it.I propose we change to
lucode
. And I guess that would be a breaking change so should go in a minor release.