natcap / invest

InVEST®: models that map and value the goods and services from nature that sustain and fulfill human life.
Apache License 2.0
170 stars 70 forks source link

Standardize field names in biophysical tables #1249

Open davemfish opened 1 year ago

davemfish commented 1 year ago

If a biophysical table is an invest input that has a row for each landcover type, then all tables need a landcover column. Most models call this column lucode, but some do not:

I propose we change to lucode. And I guess that would be a breaking change so should go in a minor release.

phargogh commented 1 year ago

This would be a very satisfying change. 👍

emlys commented 1 year ago

I think the cropname one is because there's a standard set of crops that the model supports, and so it's letting you map your arbitrary LULC classification to that fixed crop classification

newtpatrol commented 5 months ago

Just adding a +1 to this. For some reason, it's only today that I noticed that HQ uses "lulc", and was about to file an issue asking for it to be matched to the others that use "lucode", but @davemfish is already on it!