search

natcap / invest

InVEST®: models that map and value the goods and services from nature that sustain and fulfill human life.
Apache License 2.0
170 stars 70 forks source link

SDR and probably other routed models have int32 limitations #1431

Closed phargogh closed 9 months ago

phargogh commented 1 year ago

In https://github.com/natcap/pygeoprocessing/pull/351, we fixed an issue in MFD routing where rasters that had over 2^32 pixels, there would be an indexing issue and a related nodata comparison issue.

These problems with indexing also apply to all of the InVEST models that use MFD, which include SDR, NDR and SWY. @jagoldstein encountered this issue in SDR specifically (see logfile below), but we should fix the issue for all of the routed models as well.

This is important for the GEF work.

InVEST-natcap.invest.sdr.sdr-log-2023-10-17--14_22_25.txt

phargogh commented 9 months ago

This came back up with a Colombia SDR run once again.