Handle these scenarios for adding a new line item

nate-gray / KiL

0 stars 0 forks source link

Handle these scenarios for adding a new line item #48

Closed nate-gray closed 6 years ago

nate-gray commented 6 years ago

An item should not be added and an error should be displayed in these cases.

No name entered for the item.
No value entered for the current stock.
Non-int value entered for current stock.
Current stock exceeds 999.
Name exceeds 20 alphanumeric characters.
Name contains non-alphanumeric characters.

nate-gray commented 6 years ago

Linked issue: https://github.com/ngray311/KiL/issues/18

JRHummel commented 6 years ago

Is there a reason to limit stock values and max name characters besides that we made it a requirement?

nate-gray commented 6 years ago

This is strictly based off the requirements. I think part of the reason we added that requirement was that so we had something to shoot for. I am sure we could find a max value for each of them that would start breaking things, but definitely not a major issue.

So I guess it just depends on how strict we want to be with our original requirements.

Waterski24 commented 6 years ago

handled in my latest pull request

nate-gray commented 6 years ago

Looks good.