search

nate-parrott / Flashlight

The missing Spotlight plugin system
http://flashlight.nateparrott.com
Other
5.39k stars 411 forks source link

Crashes when input some Chinese characters. #165

Closed hirakujira closed 9 years ago

hirakujira commented 9 years ago

I found that Flashlight crashes when I try to input some Chinese characters. For example, 「天線」(Traditional Chinese) makes spotlight crashes. It's safe if you copy the character to spotlight, to reproduce this problem, you should enable Chinese Traditional Input Method - Pinyin, enable it, then type "tianxian" in spotlight.

nate-parrott commented 9 years ago

Seems to work for me... which plugin are you using with it? On Fri, Dec 5, 2014 at 1:27 PM Hiraku notifications@github.com wrote:

I found that Flashlight crashes when I try to input some Chinese characters. For example, 「天線」(Traditional Chinese) makes spotlight crashes. It's safe if you copy the character to spotlight, to reproduce this problem, you should enable Chinese Traditional Input Method - Pinyin, enable it, then type "tianxian" in spotlight.

— Reply to this email directly or view it on GitHub https://github.com/nate-parrott/Flashlight/issues/165.

hirakujira commented 9 years ago

I tried to disable all plugins but it still crashes. However when I tried to disable flashlight, it works. Here's the crash log

2014/12/06 2:50:00.468 Spotlight[14238]: *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSCFConstantString stringByAppendingString:]: nil argument'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007fff8a0a666c __exceptionPreprocess + 172
    1   libobjc.A.dylib                     0x00007fff90e0176e objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff8a0a651d +[NSException raise:format:] + 205
    3   Foundation                          0x00007fff8c2dbaee -[NSString stringByAppendingString:] + 96
    4   SpotlightSIMBL                      0x00000001133fe7ca __SS_markPathExecutable + 2666
    5   Foundation                          0x00007fff8c4cbe73 -[NSLinguisticTagger enumerateTagsInRange:scheme:options:usingBlock:] + 16005
    6   SpotlightSIMBL                      0x00000001133fe706 __SS_markPathExecutable + 2470
    7   SpotlightSIMBL                      0x00000001133fe0ff __SS_markPathExecutable + 927
    8   SpotlightSIMBL                      0x00000001133f87e5 __SS_Start + 332
    9   libdispatch.dylib                   0x00007fff89981323 _dispatch_call_block_and_release + 12
    10  libdispatch.dylib                   0x00007fff8997cc13 _dispatch_client_callout + 8
    11  libdispatch.dylib                   0x00007fff8997f88f _dispatch_root_queue_drain + 935
    12  libdispatch.dylib                   0x00007fff8998dfe4 _dispatch_worker_thread3 + 91
    13  libsystem_pthread.dylib             0x00007fff949ae637 _pthread_wqthread + 729
    14  libsystem_pthread.dylib             0x00007fff949ac40d start_wqthread + 13
)

BTW, I'm using OS 10.10.2 (14C68m), not sure whether it only happens on 10.10.2...

nate-parrott commented 9 years ago

This is interesting... I'll check it out once I fix the (much bigger) issue with the newer 10.10.2 seed. Thanks for the logs! On Fri, Dec 5, 2014 at 1:52 PM Hiraku notifications@github.com wrote:

I tried to disable all plugins but it still crashed. However when I tried to disable flashlight, it works. Here's the crash log

2014/12/06 2:50:00.468 Spotlight[14238]: * Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '* -[NSCFConstantString stringByAppendingString:]: nil argument' *\ First throw call stack: ( 0 CoreFoundation 0x00007fff8a0a666c exceptionPreprocess + 172 1 libobjc.A.dylib 0x00007fff90e0176e objc_exception_throw + 43 2 CoreFoundation 0x00007fff8a0a651d +[NSException raise:format:] + 205 3 Foundation 0x00007fff8c2dbaee -[NSString stringByAppendingString:] + 96 4 SpotlightSIMBL 0x00000001133fe7ca SS_markPathExecutable + 2666 5 Foundation 0x00007fff8c4cbe73 -[NSLinguisticTagger enumerateTagsInRange:scheme:options:usingBlock:] + 16005 6 SpotlightSIMBL 0x00000001133fe706 __SS_markPathExecutable + 2470 7 SpotlightSIMBL 0x00000001133fe0ff SS_markPathExecutable + 927 8 SpotlightSIMBL 0x00000001133f87e5 __SS_Start + 332 9 libdispatch.dylib 0x00007fff89981323 _dispatch_call_block_and_release + 12 10 libdispatch.dylib 0x00007fff8997cc13 _dispatch_client_callout + 8 11 libdispatch.dylib 0x00007fff8997f88f _dispatch_root_queue_drain + 935 12 libdispatch.dylib 0x00007fff8998dfe4 _dispatch_worker_thread3 + 91 13 libsystem_pthread.dylib 0x00007fff949ae637 _pthread_wqthread + 729 14 libsystem_pthread.dylib 0x00007fff949ac40d start_wqthread + 13 )

BTW, I'm using OS 10.10.2 (14C68m), not sure whether it only happens on 10.10.2...

— Reply to this email directly or view it on GitHub https://github.com/nate-parrott/Flashlight/issues/165#issuecomment-65836089 .

xremix commented 9 years ago

Might be related to #172 Is this only happening for Plugins that directly enter external Websites like the Wiki Plugin? Or also to those that display local HTML files like the Timezone plugin?

hirakujira commented 9 years ago

This happening when flashlight is enabled (even if I deleted ~/Library/FlashlightPlugins). If I disable Flashlight, spotlight won't crash.

Video here: http://youtu.be/lEoN-LJE-tw

nate-parrott commented 9 years ago

172 seems like more of a python-side issue — this is a crash in ObjC code.

Could you tell me what exactly you're typing to get it to crash?

nate-parrott commented 9 years ago

can't reproduce — please reopen if you have more info.