Selection text color - Githubissues

jcavar commented 9 years ago

screen shot 2014-12-15 at 15 03 32

If you select plugin in a list it is not looking good. I thought that this is easy task, but it seems that there is some work to do to fix this. I think that reason for this is that current architecture violates MVC. Here is what i think about it:

PluginModel shouldn't have attributedString mehtod. This should belong to PluginCellView because this is how data is presented to user.
In MainMenu.xib PluginCellView should have separate text fields for title, description and tags
Title, description and tag fields should be bound directly to model fields
Then we can bind text color to PluginCellView property so it can be changed when user select cell

Do you agree with this? If yes and if you want I can start working on this.

nate-parrott commented 9 years ago

You're right — that part of the code isn't the prettiest. If you want to take a shot at cleaning it up, you're welcome to :smile:

I'm actually not sure if the cells should be selectable at all — there's nothing you can do with them once they're selected...

ghost commented 9 years ago

I would recommend to deactivate the hole selection of cells there... It doesn't make sense :-)

nate-parrott commented 9 years ago

Yep, that's what I think I'll do for now

xremix commented 9 years ago

@nate-parrott this already changed, right? I think this issue can be closed.

nate-parrott / Flashlight

Selection text color #198