search

nate-parrott / Flashlight

The missing Spotlight plugin system
http://flashlight.nateparrott.com
Other
5.39k stars 411 forks source link

Phrases for messages, reminders, mail, etc., are converted to lower case #238

Closed toph-allen closed 9 years ago

toph-allen commented 9 years ago

If I type, for instance, "message toph, What's up?", the resultant message is all in lower case. The same's true for the Reminders and Mail plug-ins.

screen shot 2014-12-29 at 4 25 22 pm

I'm not sure whether this is a decision on the part of the plug-in or the framework, but it would seem more in keeping with Apple's style to auto-sentence case things, or at the very least to let the user's capitalization stick.

nate-parrott commented 9 years ago

That's an issue with the current parser. I'm working on a new one (in the new-engine branch) which should fix this. It'll be ready in the next release. On Mon, Dec 29, 2014 at 4:25 PM Toph notifications@github.com wrote:

If I type, for instance, "message toph, Hey, what's up?", the resultant message is all in lower case. The same's true for the Reminders and Mail plug-ins.

[image: screen shot 2014-12-29 at 4 23 40 pm] https://cloud.githubusercontent.com/assets/3117884/5573200/12866542-8f77-11e4-917c-6f66456732df.png

I'm not sure whether this is a decision on the part of the plug-in or the framework, but it would seem more in keeping with Apple's style to auto-sentence case things, or at the very least to let the user's capitalization stick.

— Reply to this email directly or view it on GitHub https://github.com/nate-parrott/Flashlight/issues/238.

nate-parrott commented 9 years ago

This should be fixed in the latest release. I'm holding off on pushing it out as an auto-update, because it's not heavily tested yet, but please try it out.

toph-allen commented 9 years ago

This is indeed fixed. Thanks so much!