search

nate-parrott / Flashlight

The missing Spotlight plugin system
http://flashlight.nateparrott.com
Other
5.39k stars 411 forks source link

Updated weather plugin - replace core. #346

Closed SebastianGrans closed 9 years ago

SebastianGrans commented 9 years ago

Replaced the core plugin as per request.

I also implemented i18n for german and dutch. I didn't feel comfortable with translating the french version so I renamed those files to fixme_*.

Enjoy!

nate-parrott commented 9 years ago

Why do we need to delete the French files? (as opposed to keeping them around and just not supporting the new functionality in French)

Maybe we should re-organize the way localization works for this plugin?

SebastianGrans commented 9 years ago

I'm quite new to git and there were some problems when I copied files between the new and the old plugin. So that commit comment refers to deleting doublet french files. The french files are still there under the prefix "fixme_".

I think that we should remove the language specific HTML files and rely fully on the strings.json files. I'll look into it when I have some time over! :)

nate-parrott commented 9 years ago

definitely — I'll take a look at it too.

On Sun, Mar 1, 2015 at 4:02 PM, Sebastian Grans notifications@github.com wrote:

I'm quite new to git and there were some problems when I copied files between the new and the old plugin. So that commit comment refers to deleting doublet french files. The french files are still there under the prefix "fixme_".

I think that we should remove the language specific HTML files and rely fully on the strings.json files. I'll look into it when I have some time over! :)

— Reply to this email directly or view it on GitHub https://github.com/nate-parrott/Flashlight/pull/346#issuecomment-76630480 .