nate-parrott / Flashlight

The missing Spotlight plugin system
http://flashlight.nateparrott.com
Other
5.39k stars 411 forks source link

Change Bitcoin API, so that more currencies are available. #437

Closed cHemingway closed 9 years ago

cHemingway commented 9 years ago

I have changed the API used to support more currencies (see commit for details), with automatic selection from localisation settings (default), and manually but my “options.json” file does not seem to work and I’m unsure why. It validates as valid JSON, but no settings appear.

Other than that, the rest of this pull request should be working. It may need some more localisation tweaks to adjust decimal places and ordering of symbol and price, which I would be happy to do if I can get the settings fixed.

nate-parrott commented 9 years ago

nice, thanks!

cHemingway commented 9 years ago

Thanks, but im afraid the settings dialog for this isn't quite working yet, I cant seem to get it to display. I submitted this pull request because the rest of the code is working and I was hoping someone might be able to help me with fixing the settings dialog. Sorry for the trouble, or if this should have better been placed as an issue.