nate-parrott / Flashlight

The missing Spotlight plugin system
http://flashlight.nateparrott.com
Other
5.39k stars 411 forks source link

Fix FlashlightKit build from source by removing .pyc references #470

Closed cHemingway closed 9 years ago

cHemingway commented 9 years ago

FlashlightKit references two .pyc files, invoke_plugin.pyc and run_plugin.pyc which do not exist.

This pull request removes references to them, and the copying of them during build, so that the project can be built from source.

cHemingway commented 9 years ago

Whoops, should have checked the commit log more thoroughly, I see in 26e6fc258a1f90d09cb30fc0c9bd5252925e3467 that you deliberately chose to do this, and so this pull request would break run() in plugins.

I think the solution is then to either commit the .pyc files, or change the behaviour of pressEnter back to using .py files. The latter sounds cleaner to me, but I don't know why the change was needed to bootstrap with .pyc files to start with. Could using .pyc files be a possible cause of #98?