search

nate-parrott / Flashlight

The missing Spotlight plugin system
http://flashlight.nateparrott.com
Other
5.39k stars 411 forks source link

My plugin isn't matched by the regex #79

Closed lbrndnr closed 10 years ago

lbrndnr commented 10 years ago

I've already mentioned you a couple days ago. Here's my fork. It's a plugin that let's you call/facetime people from within the addressbook.

frdmn commented 10 years ago

Whats the intention with this issue? To merge your new plugin? If so, please submit a pull request that contains your changes.

Btw: nice plugin :)

lbrndnr commented 10 years ago

Well I thought it's kinda weird to merge something that isn't working…

frdmn commented 10 years ago

Yeah, totally agree. I just wasn't quite sure what you expect. Got it :)

nate-parrott commented 10 years ago

That sounds really cool, but I can't actually find your Facetime plugin in the fork — where is it? I'd love to get it working + merge it.

lbrndnr commented 10 years ago

Oh sorry, it's in the sociial branch.

nate-parrott commented 10 years ago

I don't see any regexes in your examples.txt (https://github.com/larcus94/Flashlight/blob/social/PluginDirectories/1/phone.bundle/examples.txt). Does it work? I'll try to check it out when I get home.

lbrndnr commented 10 years ago

Hm okay, might not be a regex. The problem is that when I type call [somebodysname] the plugin doesn't show up at all.

nate-parrott commented 10 years ago

It looks like your plugin is being matched by the parser and then crashing in plugin.py. This looks really useful — here's a couple tips:

lbrndnr commented 10 years ago

Oh gosh, how could I have missed that. Hope you didn’t spend too much time on this. Did you do the contacts module just recently? Hm that seems kind of counterintuitive considering a scenario where a user, basically everyone with more than 20 friends, has two friends with the same name. If a friend of mine knew two laurins, he probably wouldn’t want to spell out laurin b but something like lau br. Otherwise it kind of defeats the idea of having a fast way to call somebody---

On 23 Nov 2014, at 21:57, Nate Parrott notifications@github.com wrote:

It looks like your plugin is being matched by the parser and then crashing in plugin.py. This looks really useful — here's a couple tips:

you can see if your plugin is crashing in console.app — look for lines like "querying spotlight plugins" for "running spotlight plugins" and expand them you may want to use the contacts module https://github.com/nate-parrott/Flashlight/blob/master/UsefulModulesForPlugins/contacts.py for searching contacts, so you can avoid writing/debugging it yourself you should probably do contacts search only after pressing enter — it's not really fast enough right now to do in every results() call (every time the user types a keystroke) — Reply to this email directly or view it on GitHub https://github.com/nate-parrott/Flashlight/issues/79#issuecomment-64134282.

lbrndnr commented 10 years ago

Hm alright I tried fixing it but the problem is that although I have in the example.txt file a line saying call ~name(John Appleseed)the parsed dictionary does not contain a value called name. Am I missing something here?

nate-parrott commented 10 years ago

The value will be called ~name. Sorry for the confusion! On Fri, Nov 28, 2014 at 11:41 AM Laurin Brandner notifications@github.com wrote:

Hm alright I tried fixing it but the problem is that although I have in the example.txt file a line saying call ~name(John Appleseed)the parsed dictionary does not contain a value called name. Am I missing something here?

— Reply to this email directly or view it on GitHub https://github.com/nate-parrott/Flashlight/issues/79#issuecomment-64911840 .