search

nate-strauser / meteor-analyticsjs

Analytics.js packaged for Meteor
https://atmospherejs.com/natestrauser/analyticsjs
14 stars 4 forks source link

Warn about lack of API key #7

Closed dandv closed 10 years ago

nate-strauser commented 10 years ago

looks ok, but dont we need to do some console detection? iirc certain browsers (IE not sure which version) will stop js execution if console isnt available and you attempt to use it

dandv commented 10 years ago

Apparently it's IE8. Doesn't Meteor already take care of polyfill-ing or disabling the console, like in this example? I haven't quite tested that and I don't have access to IE8.

nate-strauser commented 10 years ago

i dont think it does - i recall blank white screens in IE8 when console was used - this looks ok to me - if it becomes an issue, we could always just put the check/warn in server side code (might be more likely to be noticed there anyway)