search

nate-strauser / meteor-select2

Select2 bindings to meteor
MIT License
30 stars 24 forks source link

fix path overrides for select 3.4.2 #1

Closed lacco closed 11 years ago

lacco commented 11 years ago

The path overrides has been the only issues I had with 3.4.2, everything else seems to work fine.

nate-strauser commented 11 years ago

thank, but placeholders still arent working for me -- i'm going to hold on publishing to atmosphere for now

lacco commented 11 years ago

Thanks for merging! Pushing to atmosphere is not necessary for me, I am just using your master branch directly ("select2": {"git": "git@github.com:nate-strauser/meteor-select2.git"}). I had to upgrade to 3.4.2 because there were some weird behavior with using Bootstrap's modal with select2 3.4.0.

nate-strauser commented 11 years ago

just curious, do placeholders work for you? i suppose my problem could be my app, just havent devoted the time to pinpoint whatever is breaking them for me.

On Fri, Sep 20, 2013 at 5:57 AM, Kai Schlichting notifications@github.comwrote:

Thanks for merging! Pushing to atmosphere is not necessary for me, I am just using your master branch directly ("select2": {"git": "git@github.com:nate-strauser/meteor-select2.git"}). I had to upgrade to 3.4.2 because there were some weird behavior with using Bootstrap's modal with select2 3.4.0.

— Reply to this email directly or view it on GitHubhttps://github.com/nate-strauser/meteor-select2/pull/1#issuecomment-24800329 .

lacco commented 11 years ago

I just added placeholder: "Foo" to one of my select2 calls, and it works for me. Nevertheless, I just saw that select2 3.4.3 has been released, and https://github.com/ivaynberg/select2/issues/1614 fixes passing the placeholder via attribute (<input type="hidden" placeholder="Foo" />). Perhaps this fixes your issues, too?

nate-strauser commented 11 years ago

3.4.3 did it for me, published that version to atmosphere - thanks again for your help

On Mon, Sep 23, 2013 at 4:09 AM, Kai Schlichting notifications@github.comwrote:

I just added placeholder: "Foo" to one of my select2 calls, and it works for me. Nevertheless, I just saw that select2 3.4.3 has been released, and ivaynberg/select2#1614 https://github.com/ivaynberg/select2/issues/1614fixes passing the placeholder via attribute (<input type="hidden" placeholder="Foo" />). Perhaps this fixes your issues, too?

— Reply to this email directly or view it on GitHubhttps://github.com/nate-strauser/meteor-select2/pull/1#issuecomment-24904269 .