search

nate-strauser / meteor-x-editable-bootstrap

Smart package for x-editable in place editor
80 stars 51 forks source link

Depend on the official integration at twbs:bootstrap #31

Closed mizzao closed 9 years ago

mizzao commented 9 years ago

Updated the package to use twbs:bootstrap instead of mizzao:bootstrap-3.

mizzao commented 9 years ago

Also made the dependency weak so that other packages like nemo64:bootstrap can be used (mizzao/meteor-x-editable-bootstrap#1), thanks @1024kilobyte.

nate-strauser commented 9 years ago

thanks!

paulbalomiri commented 9 years ago

Could you also add a weak dependency for nemo64:bootstrap?

1024kilobyte commented 9 years ago

What do you need it for? The current dependency for bootstrap is already weak, so you can use any bs package you want, as @mizzao already mentioned before: Also made the dependency weak so that other packages like nemo64:bootstrap can be used

paulbalomiri commented 9 years ago

Yes, but the weak dependency influences the load order. Right now i cannot use nemo64:bootstrap because the popover.js file is loaded after this package.

The weak dependency would fix the load order. See this issue #14 in nemo64/meteor-bootstrap.