search

nate-strauser / wework

We Work Meteor, a job board and developer directory for Meteor specific work
https://www.weworkmeteor.com
MIT License
288 stars 145 forks source link

Spiderable throws TypeError due to phantomjs 1.9.9 #38

Open jorisbontje opened 9 years ago

jorisbontje commented 9 years ago

When checking spiderable with http://www.weworkmeteor.com/?_escaped_fragment_= I get the following result on the top of my page:

TypeError: 'undefined' is not a function (evaluating 'n[i].bind(this)')
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204 in h
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:208
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:1
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:208
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:3
 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:3

Upgrading phantomjs to 2.0 helps locally, but dfischer:phantomjs (which installs phantomjs on modulus.io) is still set to 1.9.9

Not sure if this impacts SEO negatively.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9103747-spiderable-throws-typeerror-due-to-phantomjs-1-9-9?utm_campaign=plugin&utm_content=tracker%2F515572&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F515572&utm_medium=issues&utm_source=github).
nate-strauser commented 9 years ago

ok - maybe i can just fork the package and upgrade to 2.0

On Mon, Mar 2, 2015 at 3:24 AM, Joris Bontje notifications@github.com wrote:

When checking spiderable with http://www.weworkmeteor.com/?_escaped_fragment_= I get the following result on the top of my page:

TypeError: 'undefined' is not a function (evaluating 'n[i].bind(this)') http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:204 in h http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:208 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:1 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:208 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:3 http://www.weworkmeteor.com/0cf56248393014d9050a6154a75a1864d304f8ce.js:3

Upgrading phantomjs to 2.0 helps locally, but dfischer:phantomjs (which installs phantomjs on modulus.io) is still set to 1.9.9

Not sure if this impacts SEO negatively.

— Reply to this email directly or view it on GitHub https://github.com/nate-strauser/wework/issues/38.