search

nate-strauser / wework

We Work Meteor, a job board and developer directory for Meteor specific work
https://www.weworkmeteor.com
MIT License
288 stars 145 forks source link

Where is search function? #79

Closed daveeel closed 8 years ago

daveeel commented 8 years ago

Can't find such function. Is search function planned?

nate-strauser commented 8 years ago

currently there is no search, but it is planned for developers/profiles

On Fri, Dec 4, 2015 at 3:08 AM, Dave Lee notifications@github.com wrote:

Can't find such function. Is search function planned?

— Reply to this email directly or view it on GitHub https://github.com/nate-strauser/wework/issues/79.

ritchieng commented 8 years ago

+1

pddew commented 8 years ago

+1

hafizali05 commented 8 years ago

@nate-strauser I have implemented search in my last project and technically this is my first ever open source contribution if I am allowed to start search using easysearch.

nate-strauser commented 8 years ago

i'm not sure that easysearch will be viable with the existing infinite scroll behavior

probably just need to do plain mongo full text searching see https://www.okgrow.com/posts/guide-to-full-text-search-in-meteor

see https://github.com/nate-strauser/wework/blob/master/server/publications.js#L231 https://github.com/nate-strauser/wework/blob/master/client/views/profiles/profiles.js#L2 slightly customized version of infinite scroll package - https://github.com/nate-strauser/wework/tree/master/packages/meteor-infinite-scroll

i'm not opposed to easy search, but i do like the infinite scrolling, which doesnt seem to work with easysearch https://github.com/matteodem/meteor-easy-search/search?q=infinite&type=Issues&utf8=%E2%9C%93

nate-strauser commented 8 years ago

@hafizali05 i implemented basic searching. you could extend it with a PR if you want (searching for other attributes). getting it to work with infinite scrolling was a little tricky.

hafizali05 commented 8 years ago

@nate-strauser would love to do that, thanks :)