search

nate-xyz / resonance

Intuitive GTK4/LibAdwaita music player
https://beta.flathub.org/apps/io.github.nate_xyz.Resonance
GNU General Public License v3.0
363 stars 20 forks source link

Artist album catalogue flickering bug #20

Open Protrikk opened 1 year ago

Protrikk commented 1 year ago

What I assume is happening is whenever a name of a track in an album is long enough and hovered over, window tries to realign the layout to make space for the additional buttons that appear on the sides of the track. It's immiedietly being not hovered over again and realigned resulting in a shimmering loop.

Nagranie ekranu z 2023-04-07 20-07-52.webm

Protrikk commented 1 year ago

It just changes the layout in the video, but it flickers around in reality

nate-xyz commented 1 year ago

This is because the album card is a flowbox like I mentioned in (https://github.com/nate-xyz/resonance/issues/22#issuecomment-1500681500), and the track button resizes on hover due to the label width + the play icon, which changes the overall width of the flowbox child. Unfortunately the fix I implemented depends on specific font width, so I need to redo it for the GNOME default font I think

Protrikk commented 1 year ago

Doing something for a specific font and size doesn't sound like the right solution, it would brake again even if someone enables the big text option. I think it'd be better to have the buttons which show up when hovered be overlayed on top instead

LukaszH77 commented 1 year ago

Another example of this behavior. It really hurts my eyes when it happens. Warning: flashing images.

Screencast from 2023-04-08 00.30.07.webm

nate-xyz commented 1 year ago

Doing something for a specific font and size doesn't sound like the right solution, it would brake again even if someone enables the big text option. I think it'd be better to have the buttons which show up when hovered be overlayed on top instead

yeah that's a good point, I think I'll switch it to an overlay.