search

nate-xyz / resonance

Intuitive GTK4/LibAdwaita music player
https://beta.flathub.org/apps/io.github.nate_xyz.Resonance
GNU General Public License v3.0
361 stars 20 forks source link

The same artist can be separated into different buttons with the same name #21

Open Protrikk opened 1 year ago

Protrikk commented 1 year ago

Some of the artists in my library are separated into multiple artist pages despite all of the songs being tagged with the same album artist tag and displaying with the same name. Additionally I've seen some being separated for unkown reasons but instead starting with non-capital. Sadly I wasn't able to spot a pattern to this but I'll peep around a bit more

Protrikk commented 1 year ago

The tracks with the 'album artist' tag are separated from those with just 'artist' tag in one of the cases. I believe they should be packed together if the outcoming name is the same. I thought I had those tagged with album artist but apparently not since they displayed fine in lollypop

nate-xyz commented 1 year ago

So are you saying if a track doesn't have an albumartist tag, it should use its artist tag?

Protrikk commented 1 year ago

yea, i guess. I don't know how that stuff works in the back

Protrikk commented 1 year ago

obraz to clear things up just in case, dj sound on the left side is the one with tracks without album artist tagged, on the right with album artist tagged. They shouldn't be split but grouped together

nate-xyz commented 1 year ago

to clear things up just in case, dj sound on the left side is the one with tracks without album artist tagged, on the right with album artist tagged. They shouldn't be split but grouped together

In this case, they aren't the same tag because the grouping is case-sensitive. This isn't a bug, but an issue with your tags. I could change the grouping on import to be case-insensitive but then the issue is determining which case-sensitive version of the tag to display (ie DJ Sound vs Dj Sound)

nate-xyz commented 1 year ago

The tracks with the 'album artist' tag are separated from those with just 'artist' tag in one of the cases. I believe they should be packed together if the outcoming name is the same. I thought I had those tagged with album artist but apparently not since they displayed fine in lollypop

I think this is related to: https://github.com/nate-xyz/resonance/issues/52

Protrikk commented 1 year ago

No oopsss, I genuinly didn't notice the different casing. Ig the thing with album artist tag not being there was a coincidence, my bad. I think the grouping should be case insensitive though

As to which version should be preffered in case it would be case insensitive, I guess whichever there is more and in the case there is the same amount of trakcs resulting in the same outcome, it shouldn't really matter?