search

nateP82 / compostCollectors

Repo for the compost collection site
0 stars 0 forks source link

Project checkpoint #2 #3

Open nateP82 opened 1 year ago

nateP82 commented 1 year ago

@pawaitemadisoncollege My individual project checkpoint 2 is ready for review.

I have the database created and connected for testing. I set up both a test, and a "production" database, but for now I have only populated the test database.

I've added a UserDao and PickupServiceDao with crud capabilities. I also added a GenericDao. I am thinking I will refactor these or add daos as needed as my project progresses, but for now they are tested using the generic dao by passing in the type of class for each set of tests.

I started building out some of the flows for creating an account, reading an account, etc. However, I haven't completed the week 7 work yet and it sounds like this will be done with the AWS Cognito service. I'll refactor those servlets and jsps after I get the cognito service working.

pawaitemadisoncollege commented 1 year ago

Hi @nateP82! Your project is really coming along nicely!

Checkpoint goals:

  1. Database designed and created: is there an ERD available for review? This can be created in IntelliJ's database view if you don't already have a preferred way to generate one.

  2. At least one DAO with full CRUD (create, read, update, delete) implemented with Hibernate and DAO is fully unit tested. Nice job implementing the generic dao! I think you should be able to delete the UserDao and PickupServiceDao now, is that correct? Testing could be improved by verifying the delete scenarios with relationships. If a pickup service associated with a user is deleted, what happens to the user? If a user with pick up services is delete, what happens to the service? Write unit tests to make sure what should happen does happen.

  3. Log4J is implemented (no System.out.printlns) - no printlns found, and a quick review shows log statements are present.

  4. Project plan: check off completed tasks, and consider moving incomplete items forward to an upcoming week. https://github.com/nateP82/compostCollectors/blob/master/Development/projectPlan.md. Time log is current through week 6.

Other

I took a few minutes to review other aspects of your project such as jsps and controllers. Things are looking good so far!

You might consider using a jquery data table (introduced in the user display exercise solution) to add sorting and searching capability within results tables.

Keep up the good work @nateP82!