search

nateP82 / compostCollectors

Repo for the compost collection site
0 stars 0 forks source link

Indie Project checkpoint 3 #4

Open nateP82 opened 1 year ago

nateP82 commented 1 year ago

@pawaitemadisoncollege I've got my project deployed to an aws instance and I've implemented cognito for auth: CompostCollectors

I don't have any styling yet and the login link is borrowed from the week 7 cognito exercise. This link is located on the index.jsp page, and when you click it you should be asked to sign in, or sign up. I do have a user in my user pool if you need credentials to sign in.

One other note, the View Account link is currently the only working link on the index page. If you click it, you should be able to search for a user by last name, like Curry, and it will return the results. That's all I have for the time being, I'm working on the rest.

Thanks!

pawaitemadisoncollege commented 1 year ago

Hi @nateP82! Congrats on hitting checkpoint 3!

I tested out your deployed app on AWS and was able to sign up, sign in and view data in a JSP. Consider continuing to make regular deployments as you put the polish on this over the next two weeks.

I took a bit of time to review the code written so far as well and while much of this is likely on your radar, I wanted to make sure I shared what I noticed:

  1. You are following many of the best practices and coding standards. Things look pretty clean at this point!
  2. Signing up does not at the user to the database. I put a suggested flow for this in slack #indie-project on March 3. Some others have implemented this already, so if you have questions about completing this portion, there's some good knowledge out there already.
  3. In reviewing your project plan, there are some items that may not be required and you could consider pushing to V2. I recommend focusing on demonstrating some of the key objectives that are not yet achieved: full crud w/ one-to-many relationships and consuming an api (consuming at least one resource from your team project will meet this).
  4. Consider using jstl tags for imports rather than directives. JSTL tags tend to be industry best practice as this point (you may still need a directive to import that taglib). https://github.com/nateP82/compostCollectors/blob/a05028c89915418c904202213a6b3ee4a0d2b16a/src/main/webapp/index.jsp#L4-L10
  5. With the implementation of the GenericDao, you should not need the other entity-specific Daos (delete them - if you ever need them again, you they will still be version in git).
  6. Delete scenario unit testing should include the one-to-many relationship. If I delete a user, what should happen to their PickupService and vice versa? Write tests to make sure what should happen, does happen.
  7. Be sure to include descriptive comments before the classes too. https://github.com/nateP82/compostCollectors/blob/a05028c89915418c904202213a6b3ee4a0d2b16a/src/test/java/com/compostcollectors/persistence/PickupServiceDaoTest.java#L13-L14

Looking forward to seeing the final product, Nate!