search

natecavanaugh / convert-bootstrap-2-to-3

Convert Bootstrap 2 variables, class names and HTML to Bootstrap 3
MIT License
3 stars 9 forks source link

Jinjia templates #5

Open therealmarv opened 8 years ago

therealmarv commented 8 years ago

Not a big issue but it got me some trouble for 2 minutes: Jinjia variables (which is essentially python) in templates were overwritten with bs3 -i *.html.

See code example here https://github.com/PyBossa/pybossa-default-theme/commit/2a3d148ff63dfb72fb3d0c4bdf4ddf8c2ba0811b#diff-8944b57466f08564caa53a1988261ae0R5 or also here https://github.com/PyBossa/pybossa-default-theme/commit/2a3d148ff63dfb72fb3d0c4bdf4ddf8c2ba0811b#diff-8944b57466f08564caa53a1988261ae0R8

natecavanaugh commented 8 years ago

Thanks for reporting this. I'll take a look at pulling those (and other similar script blocks, such as <% %>, <? ?>, and {{ }}) script blocks from the html before doing the replacement.