nateemma / strategies

Custom trading strategies using the freqtrade framework
329 stars 88 forks source link

simdkalman filter processor issues #3

Closed tomjrtsmith closed 1 year ago

tomjrtsmith commented 1 year ago

Hey Phill, I've been trying to run several of your KalmanSIMD strats and I'm seeing (I think...) the simdkalman package consume an entire processor thread which won't allow the strat to run. Wondered if you'd experienced the same or knew a workaround.

nateemma commented 1 year ago

It worked fine for me, but I run on a Mac, so it could be different. Also, I haven't touched those strategies in many months - I found that the predictions didn't work well for simdkalman, plus they are very slow (as you mention). There are also the 'regular' Kalman filter Strats that use pykalman

tomjrtsmith commented 1 year ago

I ran it on a vps instance and it wouldn't multithread, I think because of the SIMD filter. I've found the DWT strats work best so far, still working my way through them all.

tomjrtsmith commented 1 year ago

sklearn is throwing out this error when I got Anomaly running. I'm also noticing some memory bleed, I think from tensorflow (seems worse on the PCA/LSTM strats) but still noticeable using sklearn. I've had trouble getting finta to run so edited out VFI and made some edits in my fork around some of your custom settings and they seem to run ok. Accuracy is amazing.

/home/ubuntu/freqtrade/.env/lib/python3.10/site-packages/sklearn/metrics/_classification.py:1334: UndefinedMetricWarning: Precision and F-score are ill-defined and being set to 0.0 in labels with no predicted samples. Use zero_division parameter to control this behavior.

nateemma commented 1 year ago

This happens when you get 0 buy/sell signals in the test data (because some of the metrics divide by that). It doesn’t affect logic, but it does indicate that maybe the buy/sell triggers are too tight

Cheers

Phil

On Wed, Dec 21, 2022 at 5:21 PM tom s @.***> wrote:

sklearn is throwing out this error when I got Anomaly running. I'm also noticing some memory bleed, I think from tensorflow (seems worse on the PCA/LSTM strats) but still noticeable using sklearn. I've had trouble getting finta to run so edited out VFI and made some edits in my fork around some of your custom settings and they seem to run ok. Accuracy is amazing.

/home/ubuntu/freqtrade/.env/lib/python3.10/site-packages/sklearn/metrics/_classification.py:1334: UndefinedMetricWarning: Precision and F-score are ill-defined and being set to 0.0 in labels with no predicted samples. Use zero_division parameter to control this behavior.

— Reply to this email directly, view it on GitHub https://github.com/nateemma/strategies/issues/3#issuecomment-1362280734, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABD4X5ZF5UFFIIZI7BG4MDDWOOUIXANCNFSM6AAAAAATAGWRXA . You are receiving this because you commented.Message ID: @.***>

nateemma commented 1 year ago

BTW, not sure when you forked, but I stopped using VFI a while ago - it sometimes returns infinite numbers, which messes up my normalisation code for the PCA/NNBC/Predict/Anomaly classes

Also, accuracy from the PCA classes is 'too good', which implies there is some lookahead bias somewhere. I think it might be in the stoploss/custom sell code since the results are very dramatically affected by those hyper parameters. Still trying to figure this one out...

Cheers,

Phil

On Wed, Dec 21, 2022 at 5:26 PM Phil Price @.***> wrote:

This happens when you get 0 buy/sell signals in the test data (because some of the metrics divide by that). It doesn’t affect logic, but it does indicate that maybe the buy/sell triggers are too tight

Cheers

Phil

On Wed, Dec 21, 2022 at 5:21 PM tom s @.***> wrote:

sklearn is throwing out this error when I got Anomaly running. I'm also noticing some memory bleed, I think from tensorflow (seems worse on the PCA/LSTM strats) but still noticeable using sklearn. I've had trouble getting finta to run so edited out VFI and made some edits in my fork around some of your custom settings and they seem to run ok. Accuracy is amazing.

/home/ubuntu/freqtrade/.env/lib/python3.10/site-packages/sklearn/metrics/_classification.py:1334: UndefinedMetricWarning: Precision and F-score are ill-defined and being set to 0.0 in labels with no predicted samples. Use zero_division parameter to control this behavior.

— Reply to this email directly, view it on GitHub https://github.com/nateemma/strategies/issues/3#issuecomment-1362280734, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABD4X5ZF5UFFIIZI7BG4MDDWOOUIXANCNFSM6AAAAAATAGWRXA . You are receiving this because you commented.Message ID: @.***>