search

natefaubion / purescript-run

An extensible-effects implementation
MIT License
158 stars 14 forks source link

Unlabeled alternates #13

Closed joneshf closed 6 years ago

joneshf commented 6 years ago

Re: #12.

Adds the At alternates for most all of the functions. Doesn't add unlabeled alternates for Run.Choose as that has typeclass stuff going on.

Let me know if there's anything you'd like changed.

joneshf commented 6 years ago

Oh, I just realized there are no At alternates for aff/eff. Will add later today.

joneshf commented 6 years ago

cc @natefaubion

natefaubion commented 6 years ago

Thanks! This looks good.

joneshf commented 6 years ago

Will add later today.

That turned out to be a lie :sweat_smile:.

While getting ready to add them, I realized there's runBaseAff' which requires two labels being chosen:

https://github.com/natefaubion/purescript-run/blob/425f13a88feb2337a91427e3a9af210a8222a846/src/Run.purs#L325

Didn't know what to do there, and then forgot to ping you about it. What do you think. Do you want unlabled aff/eff? If so, should runBaseAffAt' take two labels, or should there be no equivalent function?

natefaubion commented 6 years ago

I don't think it's necessary for Aff/Eff to be unlabelled because they are essentially primitive effects.