natefaubion / purescript-spork

Elm-like for PureScript
MIT License
157 stars 9 forks source link

Reworked internals #5

Closed natefaubion closed 6 years ago

natefaubion commented 6 years ago
natefaubion commented 6 years ago

@tippenein What do you think of this? I took out the Either and added application hooks.

tippenein commented 6 years ago

I really like the Interpret/ Action /Restore split. I particularly think this is much clearer too : subscribe ∷ (AppChange s i → Eff eff Unit) → Eff eff (Eff eff Unit) in relation to the new AppInstance / AppAction types.

I didn't have time to look this over in detail, but I plan on digging into it in tandem with building out a couple example apps using Spork.