search

natefinch / lumberjack

lumberjack is a log rolling package for Go
MIT License
4.76k stars 585 forks source link

V3.0 #132

Open thalesfsp opened 3 years ago

fahedouch commented 2 years ago

Hey @natefinch any idea when the V3.0 will be released ?

thalesfsp commented 2 years ago

@fahedouch Wow, I thought it got merged at some point. It's almost 1 year old now!

natefinch commented 2 years ago

Ug, sorry. I'll take a look at this in a bit.

fahedouch commented 2 years ago

@natefinch perfect! can have this https://github.com/natefinch/lumberjack/pull/158 in V3.0 plz . We need it in nerdctl https://github.com/containerd/nerdctl/pull/959/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R174

natefinch commented 2 years ago

So, I made a v3 branch, mostly because reviewing 1000 lines of someone else's code is really hard. It's up to parity with v2 right now and all the tests pass, but I don't want to cut a non-alpha release just yet, so I have some time to make sure the API is good before I lock it down.