Multiple enhancements - Githubissues

natefinch / lumberjack

lumberjack is a log rolling package for Go

MIT License

4.76k stars 585 forks source link

Multiple enhancements #158

Open fahedouch opened 2 years ago

fahedouch commented 2 years ago

upgrade to go 1.17
add the ability to set unlimited maxSize with -1
carrying https://github.com/natefinch/lumberjack/pull/97/files

Signed-off-by: Fahed DORGAA fahed_dorgaa@carrefour.com

fahedouch commented 2 years ago

cc @natefinch

natefinch commented 2 years ago

I made similar changes in the v3 branch. I'm not sure that maxsize = -1 is a good idea? Is there some other way you'd be managing file size?

fahedouch commented 2 years ago

hey @natefinch , sorry for the delayed reply. mmmh I think that maxsize=-1 can be a good solution to set unlimited size. By the way, this is what docker uses as a rule to set unlimited json log file storage. Tell me if you need to release V3