search

natefinch / lumberjack

lumberjack is a log rolling package for Go
MIT License
4.81k stars 593 forks source link

Add TestRotateMaxBackups test #203

Closed sword-jin closed 9 months ago

sword-jin commented 9 months ago

We use lumberjack in istio, we find the our rorate test case is very flake https://github.com/istio/istio/pull/48570.

Seems the problem is from lumberjack:

/tmp/go-stress-20231227T074012-3267854467
--- FAIL: TestRotateMaxBackups (0.05s)
    lumberjack_test.go:637: log-2023-12-27T07-40-20.949.txt
    lumberjack_test.go:637: log-2023-12-27T07-40-20.962.txt
    lumberjack_test.go:637: log-2023-12-27T07-40-20.976.txt
    lumberjack_test.go:637: log.txt
    lumberjack_test.go:639: Expecting at most 2 backup logs, but /tmp/TestRotateMaxBackups175754546/001 has 3 backups
FAIL

We need to fix it.

go version go1.21.1 linux/amd64