search

natefinch / lumberjack

lumberjack is a log rolling package for Go
MIT License
4.8k stars 591 forks source link

add_daily_log_daily #27

Closed cyuanxin closed 7 years ago

cyuanxin commented 7 years ago

hello! i have pull request.i add daily_log_daily to the project.

natefinch commented 7 years ago

Hi! Thanks so much for the work you did for the contribution. Unfortunately, I don't think rotating based on passage of time is a good idea. My argument is fully detailed here: https://github.com/natefinch/lumberjack/issues/17

cyuanxin commented 7 years ago

ok . thanks for your project and your response.