search

natefinch / lumberjack

lumberjack is a log rolling package for Go
MIT License
4.8k stars 591 forks source link

New Release #36

Open joaodlf opened 7 years ago

joaodlf commented 7 years ago

I suggest adding a new release, files have been updated recently that change the basic API (ex: Dir->Filename), but the current release is from ~4 years ago.

This complicates dependency management with glide/godep.

natefinch commented 7 years ago

Well, I wouldn't call the change recent. It was 2.5 years ago when I made v2, which is when the API changed, which also then changed the import path (it uses gopkg.in now).

However, I'll think about tagging a release, given that tools have started looking at those.

joaodlf commented 7 years ago

I understand. I installed the package through gopkg.in, but for some reason once we "glided" up one of our repos it fetched the package through github (and it went for the old release). I got a bit confused there, but this might happen to others.

nazieb commented 7 years ago

yes, this happened to me as well.

when I install this library using using go get it got the right version (v2), but when I used glide it will get the old release.

I think it's because tools like glide will check the tags for this library and check for semantic version. since the branch v2.0 is never released or tagged, the tool will ignore it.

natefinch commented 7 years ago

I'll try it out with glide. I'm surprised glide does the wrong thing, honestly.

BorisKozo commented 7 years ago

It seems glide tries to import version 1.0 but you can tell it to take latest and then it brings version 2.0

It would be nice to have a release though so that we can use glide properly

natefinch commented 7 years ago

Sorry I forgot about this one. I'll poke at it today and consider doing a release of that can fix things.