search

natefinch / lumberjack

lumberjack is a log rolling package for Go
MIT License
4.8k stars 591 forks source link

Update docs, adding `Compress` setting details #49

Closed tbutts closed 7 years ago

tbutts commented 7 years ago

I only stumbled upon this feature by accident, but it has definitely been useful. I saw that it was recently added, so I filled in the gaps in the readme, example file, and godoc.

I did try at first to reuse the godoc2md generator, but more text gets changed and reordered than I cared to fight with. This PR is simply to increase discoverability of the feature I was glad to find out about.

natefinch commented 7 years ago

Awesome, thanks, I'll take a look tonight.

On Sun, Aug 27, 2017, 10:37 AM Tyler Butters notifications@github.com wrote:

I only stumbled upon this feature by accident, but it has definitely been useful. I saw that it was recently added, so I filled in the gaps in the readme, example file, and godoc.

I did try at first to reuse the godoc2md generator, but more text gets changed and reordered than I cared to fight with. This PR is simply to increase discoverability of the feature I was glad to find out about.

You can view, comment on, or merge this pull request online at:

https://github.com/natefinch/lumberjack/pull/49 Commit Summary

  • Update docs, adding Compress setting details

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/natefinch/lumberjack/pull/49, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCcyInAnQ6EoN4DK5VqlHXDndkzgDx7ks5scX8WgaJpZM4PD0XA .

natefinch commented 7 years ago

Sorry for the delay, but thanks for the contribution! :)