search

natefinch / lumberjack

lumberjack is a log rolling package for Go
MIT License
4.78k stars 589 forks source link

Create a go.mod #65

Open andradei opened 6 years ago

andradei commented 6 years ago

To make this package module-aware.

natefinch commented 6 years ago

Yeah, I should do that. Thanks for the reminder. I'll get that done soon.

On Thu, Aug 30, 2018, 7:33 PM Isaac Andrade notifications@github.com wrote:

To make this package module-aware.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/natefinch/lumberjack/issues/65, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCcyK8Vs-AlwFHnm4mE4kvDE5kOVn7iks5uWHYtgaJpZM4WUYMB .

xiegeo commented 6 years ago

Right now the package imports fine by go mod, it shows as gopkg.in/natefinch/lumberjack.v2 v2.0.0-20170531160350-a96e63847dc3 in my downstream project.

The only problem is that the tag v2.1 is not Semver, so it probably needs a new v2.1.1 tag for it to show as v2.1.1 instead of v2.0.0-20170531160350-a96e63847dc3.

There are no build dependencies, however adding a go.mod file will help with defining test dependencies.