Open karrick opened 5 years ago
Also see https://github.com/linkedin/goavro/issues/159 where goavro
had already had a v2
branch, but wanted to create a v2
Go module.
GO111MODULE=on go mod init github.com/natefinch/lumberjack.v2
touch go.sum
GO111MODULE=on go test
git add go.{mod,sum}
git commit -m 'Created Go module'
git tag -a v2.1.1 -m 'Created Go module'
100% ... I'll tag it appropriately.... I'm sad it's already in v2, which makes modules a lot more of a headache.
I thought the same thing until someone recommended that I just call the goavro
module v2.
I made a mistake above. I should have typed:
GO111MODULE=on go mod init github.com/natefinch/lumberjack/v2
Because there is already a v2.0 branch, a v2.1 tag, it got messy, so in #89 I just created a new branch, v2.2, and tagged it v2.2.0
.
Hi @natefinch could you please tag v2.1 also as v2.1.0 ? That would allow using it in Go modules. Then the the v2.1 will be usable without problems with Go 1.11 up to Go 1.13.
I recently needed to go back to v2.0.0 because of that.
Related to #65, making it a tiny bit difficult to continue using this excellent logging library in the age of Go modules.