search

natefinch / lumberjack

lumberjack is a log rolling package for Go
MIT License
4.79k stars 591 forks source link

Please tag most recent release with number greater than all previous releases #88

Open karrick opened 5 years ago

karrick commented 5 years ago

Related to #65, making it a tiny bit difficult to continue using this excellent logging library in the age of Go modules.

*  (HEAD -> v2.0, origin/v2.0, origin/HEAD)94d9e49: Deen 2019-04-12 use 0755 to create new dir (#68)
* 4b74a4d: 康晓宁 2019-04-12 fix a typo (#62)
* 2e8fbee: Juan Osorio Robles 2019-04-11 Make default file permissions more restrictive (#83)
*  (tag: v2.0.0)7d6a187: Nate Finch 2018-08-17 Fix test timing (#64)
* aee4629: Tyler Butters 2017-09-11 Update docs, adding `Compress` setting details (#49)
* df99d62: Nate Finch 2017-05-31 switch to travis (#44)
*  (tag: v2.1, origin/master)a96e638: Joel Sing 2017-06-01 Add support for log file compression (#43)
*  (tag: v2.0)dd45e6a: Nate Finch 2016-11-04 update docs w/ backup format info
karrick commented 5 years ago

Also see https://github.com/linkedin/goavro/issues/159 where goavro had already had a v2 branch, but wanted to create a v2 Go module.

GO111MODULE=on go mod init github.com/natefinch/lumberjack.v2
touch go.sum
GO111MODULE=on go test
git add go.{mod,sum}
git commit -m 'Created Go module'
git tag -a v2.1.1 -m 'Created Go module'
natefinch commented 5 years ago

100% ... I'll tag it appropriately.... I'm sad it's already in v2, which makes modules a lot more of a headache.

karrick commented 5 years ago

I thought the same thing until someone recommended that I just call the goavro module v2.

I made a mistake above. I should have typed:

GO111MODULE=on go mod init github.com/natefinch/lumberjack/v2
karrick commented 5 years ago

Because there is already a v2.0 branch, a v2.1 tag, it got messy, so in #89 I just created a new branch, v2.2, and tagged it v2.2.0.

nightlyone commented 4 years ago

Hi @natefinch could you please tag v2.1 also as v2.1.0 ? That would allow using it in Go modules. Then the the v2.1 will be usable without problems with Go 1.11 up to Go 1.13.

I recently needed to go back to v2.0.0 because of that.