search

natefoo / slurm-drmaa

DRMAA for Slurm: Implementation of the DRMAA C bindings for Slurm
GNU General Public License v3.0
48 stars 22 forks source link

Refs #31: Single quotes in the expanded args should be escaped #33

Open stmlange opened 5 years ago

stmlange commented 5 years ago

Fixes https://github.com/natefoo/slurm-drmaa/issues/31

natefoo commented 4 years ago

Thanks @stmlange. I think you should be able to use the existing fsd_replace function for this.

stmlange commented 4 years ago

Hi, sorry for the late reply. I have incorporated your suggestion and will some additional testing....I will follow up once completed.

stmlange commented 4 years ago

Sorry for the clutter here, but I noticed that when using the existing fsd_replace function I don't need to call fsd_free -- otherwise this results in a double-free. The update I pushed caused all the linkage here :/

stmlange commented 4 years ago

Mhh after some extensive testing it seems that the fsd_replace-function causes an infinity loop.

stmlange commented 11 months ago

Since you seem active again: Is there anything I could do to get this integrated?

I should note that the previous statement still seems to be accurate: In my custom version using the fsd_replace-function seems to cause an infinity loop. Hence I'm using the proposed alternative: https://github.com/stmlange/slurm-drmaa/commit/f896f5c272004d93dfc2684f42ed313b8dca00c7

stmlange commented 11 months ago

Is there anything I could do to get this integrated (e.g. run further testing or any other experiments)?