search

natefoo / slurm-drmaa

DRMAA for Slurm: Implementation of the DRMAA C bindings for Slurm
GNU General Public License v3.0
48 stars 22 forks source link

slurm_ctl_conf_t renamed in 20.11.X #47

Closed sandynomad closed 3 years ago

sandynomad commented 3 years ago

the slurm 20.02.X structure slurm_ctl_conf_t was renamed to slurm_conf_t to 20.11.X

add a condition check for the Slurm version and then use the correct structure in the variable definition.

CristianHuza commented 3 years ago

I guess it's always a good idea to check issues/pull requests of a project, I was about to do a pull request for this exact same reason, wasted some precious time for a simple sed -i 's/slurm_ctl_conf_t/slurm_conf_t/g' test/slurm_ping.c sed -i 's/slurm_ctl_conf_t/slurm_conf_t/g' slurm_drmaa/drmaa.c

natefoo commented 3 years ago

Thanks! I'll get a release out for this shortly.