search

natefrisch01 / Graph-Link-Types

Link types for Obsidian graph view.
MIT License
82 stars 8 forks source link

Plugin still spams console on startup #9

Closed FeralFlora closed 9 months ago

FeralFlora commented 9 months ago

I know the last release says "cleanup logs", but the plugin still spams the console with hundreds of:

"New metadata, drawing graph link types."

when I start Obsidian. See screenshot:

image
natefrisch01 commented 9 months ago

Oh strange, let me try to fix this for you!

natefrisch01 commented 9 months ago

Alright, I put out a new release that should have that fixed. Thank you for letting me know, and please let me know if you find anything else - thanks!

natefrisch01 commented 9 months ago

Sorry, I didn't mean to close this until I knew it worked for you! It's interesting that it was spamming it on startup for you, because it should only do that when new metadata is added by dataview...

FeralFlora commented 9 months ago

Sorry, I didn't mean to close this until I knew it worked for you!

That's okay. I tested it now: Updated and restarted, and there was no console log from Graph link types this time. So it seems to have worked.

It's interesting that it was spamming it on startup for you, because it should only do that when new metadata is added by dataview...

Hmm, I see, that is interesting then. It was happening every startup. Dataview always indexes the vault on startup for me. Isn't that normal?

natefrisch01 commented 9 months ago

Yes, I believe so. They have 2 different events that I'm attached to, one is the initial indexing, and one is the new metadata. I'm thinking I shouldn't attach to the new metadata event until the indexing is over, because it seems like while indexing the new metadata event gets called a ton of times. Thanks for your help, I will try to account for this soon! I will address this in #12