nategood / commando

An Elegant CLI Library for PHP
MIT License
798 stars 80 forks source link

Fix invalid phpdoc types #58

Closed Jalle19 closed 8 years ago

Jalle19 commented 8 years ago

If a string parameter is type-hinted as \string, editors and code analysis tools may think that you're meaning to use a class named string from the global namespace. This causes issues when an actual string is passed to the method, leading to errors like "foo is of type string, but the function expects a object" in Scrutinizer.

Jalle19 commented 8 years ago

Here's a Scrutinizer issue for reference: https://scrutinizer-ci.com/g/Jalle19/php-tvheadend/issues/master/files/src/cli/TvheadendCommand.php?orderField=path&order=asc&honorSelectedPaths=0

Jalle19 commented 8 years ago

Ping