Closed kksligh closed 2 years ago
The biggest blocker for me on this is that I don't have a Vivint thermostat attached to my own system to be able to properly test and see the results that come back, tweak, and repeat. I follow @balansse's project and have looked at various pieces of code in it as well, but it's just a little more difficult in the testing process. I might be able to dig through it a little more and see if I can pull out some more code to make thermostats work better. Have you tried the thermostat control via this integration? I know I added minimal control, so I'm curious if you've tested that at all and found it doesn't work or just doesn't have the capabilities you want.
I tried it a while ago and it wasn't working for me. I can test it out again and report back.
On Sat, Sep 4, 2021 at 12:57 AM Nathan Spencer @.***> wrote:
The biggest blocker for me on this is that I don't have a Vivint thermostat attached to my own system to be able to properly test and see the results that come back, tweak, and repeat. I follow @balansse https://github.com/balansse's project and have looked at various pieces of code in it as well, but it's just a little more difficult in the testing process. I might be able to dig through it a little more and see if I can pull out some
more code to make thermostats work better. Have you tried the thermostat
control via this integration? I know I added minimal control, so I'm curious if you've tested that at all and found it doesn't work or just doesn't have the capabilities you want.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/natekspencer/hacs-vivint/issues/13#issuecomment-912915107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT3AQUZPQGC2RQPHZSRAPIDUAGYNPANCNFSM5DLQ6RTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Thanks,
Kale Sligh
@kksligh I just released version 2021.9.2 which should have improved support for thermostats. If you wouldn't mind checking it out and seeing if this works for you
Testing now - the hvac temp controls seem to work. However, the fan controls are throwing errors and not working
Logger: homeassistant.components.websocket_api.http.connection Source: components/climate/init.py:458 Integration: Home Assistant WebSocket API (documentation, issues) First occurred: 2:23:42 PM (13 occurrences) Last logged: 5:33:12 PM
[281473136514864] [281473136514864] Error handling message: Unknown error [281473126360544] [281472967260576] [281472935781424] Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 185, in handle_call_service await hass.services.async_call( File "/usr/src/homeassistant/homeassistant/core.py", line 1492, in async_call task.result() File "/usr/src/homeassistant/homeassistant/core.py", line 1527, in _execute_service await handler.job.target(service_call) File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 213, in handle_service await self.hass.helpers.service.entity_service_call( File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 658, in entity_service_call future.result() # pop exception if have File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 843, in async_request_call await coro File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 695, in _handle_entity_call await result File "/usr/src/homeassistant/homeassistant/components/climate/init.py", line 462, in async_set_fan_mode await self.hass.async_add_executor_job(self.set_fan_mode, fan_mode) File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run result = self.fn(*self.args, **self.kwargs) File "/usr/src/homeassistant/homeassistant/components/climate/init.py", line 458, in set_fan_mode raise NotImplementedError() NotImplementedError
Yeah, I need to add those next, hence the NotImplementedError
. But a step at a time, haha
Ah...gotcha!
On Wed, Sep 15, 2021 at 5:37 PM Nathan Spencer @.***> wrote:
Yeah, I need to add those next, hence the NotImplementedError. But a step at a time, haha
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/natekspencer/hacs-vivint/issues/13#issuecomment-920433662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT3AQU7Z27YYVVA535K2Y6TUCEN3VANCNFSM5DLQ6RTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Thanks,
Kale Sligh
Alright, @kksligh one more for you with fan mode support
So far looks great! I'll be testing it over the next day or so and let you know. I had reverted to direct z wave connection but it was spotty at best. Glad to have it back through the sky panel
On Wed, Sep 15, 2021 at 9:22 PM Nathan Spencer @.***> wrote:
Alright, @kksligh https://github.com/kksligh one more for you with fan mode support
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/natekspencer/hacs-vivint/issues/13#issuecomment-920523890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT3AQU2EV45CYFPX7IYFCCTUCFIIFANCNFSM5DLQ6RTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Thanks,
Kale Sligh
been testing for a while - I think we are good to go!
I'm currently running your integration for everything but the thermostats (amazing work and thank you for being so responsive!!!)...that said, ive stood up a docker with homeridge and using the @balansse/homebridge Vinint integration for only the thermostats that work. Have you seen this? Anything you can borrow from that to get the thermostats to work? I'm a novice at best at coding so I'm sure you know this already but I'd love to just use your integration for everything.
No worries either way. Again thank you for your work here! I definitely owe a few cups of coffee on this!