Parentheses on print in Readme.

natekupp / ffx

Fast Function Extraction

http://trent.st/ffx

Other

80 stars 93 forks source link

Parentheses on print in Readme. #27

Closed jmmcd closed 6 years ago

coveralls commented 6 years ago

Coverage remained the same at 77.294% when pulling 61a324f2f187b889a61eea6d79494ddf27b47788 on Readme-paren into 1dc24515f9b15b9b06fcf84dac5daff721612ee0 on master.

jmmcd commented 6 years ago

@natekupp it looks like I need to have a code review for my commits now! I guess this is related to the travis/coveralls stuff. Can you please review, or enable me to review myself, or something?! Thanks.

natekupp commented 6 years ago

ha, interesting. I'm not sure how to permit self-reviews, but I'm happy to CR your changes - just tag me in them and I should usually be able to review/respond within 24 hours. I just approved this one

natekupp commented 6 years ago

approved, try merging now @jmmcd ?

jmmcd commented 6 years ago

Thanks! Yes, it's probably better to have a review than a self-review, as ongoing policy.

But I don't know what to do next. I don't see a way for me to accept this pull request.

(Sorry, I am new to this part of Github.)

jmmcd commented 6 years ago

Thanks, yes rebase and merge did the right thing.