fix scikit learn interface

natekupp / ffx

Fast Function Extraction

http://trent.st/ffx

Other

80 stars 97 forks source link

fix scikit learn interface #36

Closed pizzooid closed 4 years ago

pizzooid commented 5 years ago

sklearn provides a way to check if estimators are implemented correctly: check_estimator this is now done and checked in travis ci

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 75.898% when pulling 2b696b8c5fb902590742968fe0cca8d4255c728b on pizzooid:master into 9a8b3c93d07e7ed156f71b34021fecbb573d3b11 on natekupp:master.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 75.898% when pulling 2b696b8c5fb902590742968fe0cca8d4255c728b on pizzooid:master into 9a8b3c93d07e7ed156f71b34021fecbb573d3b11 on natekupp:master.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 75.898% when pulling 2b696b8c5fb902590742968fe0cca8d4255c728b on pizzooid:master into 9a8b3c93d07e7ed156f71b34021fecbb573d3b11 on natekupp:master.

jmmcd commented 5 years ago

+1 from me @natekupp

natekupp commented 4 years ago

Hi @pizzooid - apologies for the long delay here! If you're still interested in landing this, would you mind rebasing on master? I've just landed a substantial refactor of the system after not working on this for many years

pizzooid commented 4 years ago

Replaced by #45

PS: @natekupp No worries ;-)