natemaia / dk

X11 window manager
MIT License
24 stars 0 forks source link

In some cases retroarch does not launch games #5

Closed TAforever closed 10 months ago

TAforever commented 10 months ago

Perhaps this problem is somehow related to https://github.com/natemaia/dk/issues/2. Everything related to games is tied to my workspace 3. This bug is not reproduced in 100% of cases. If I have a window open on workspace 3, then when I try to start the game in retroarch, the game does not start, but if I switch to another workspace, and then back, the game will start.

https://github.com/natemaia/dk/assets/52626363/709b66ec-8eb6-430d-98c4-cc8d9a80c4d5

natemaia commented 10 months ago

I'll look into this

natemaia commented 10 months ago

Can you check with the recent commit, I'm doing the mapping of windows immediately rather than delay it until refresh. This has other issues but I want to make sure it fixes it before I deal with them.

TAforever commented 10 months ago

If I understand you correctly, then this bug is reproduced on the last commit, as soon as a new commit is released I immediately update

natemaia commented 10 months ago

apologies, I just pushed it

TAforever commented 10 months ago

apologies, I just pushed it

I tested almost all games for different consoles and did not reproduce this bug, should I close this issue?

TAforever commented 10 months ago

Stupid question... I just thought that you wanted to fix something else in this issue

natemaia commented 10 months ago

No absolutely it can be closed. I'm gonna use this approach in more places I think, refreshing in place rather than differing them till later. It was done to save on redraws and flickering when many events happened in a short period.

The only issue I noticed is when a new window is opened while a fullscreen window is active on the workspace it causes a flicker. Not sure if it's all the time or just occasionally but it's an easy fix.

TAforever commented 10 months ago

No absolutely it can be closed. I'm gonna use this approach in more places I think, refreshing in place rather than differing them till later. It was done to save on redraws and flickering when many events happened in a short period.

The only issue I noticed is when a new window is opened while a fullscreen window is active on the workspace it causes a flicker. Not sure if it's all the time or just occasionally but it's an easy fix.

Since you mentioned flickering, I would like to inform you that the polybar flickers when the system boots when it appears. I didn't open a separate issue because the problem is too insignificant, but if you have the opportunity to fix this, that would be great.

natemaia commented 10 months ago

I can look into it, does it only happen on startup?

TAforever commented 10 months ago

Yes, this happens at startup, there is a slight “blinking”, otherwise the polybar works fine

natemaia commented 9 months ago

Please try the latest commit, I think it's either fixed or I'm just unable to reproduce.

TAforever commented 9 months ago

I tried it, unfortunately this glitch is reproducible, but I don't think there is any need to worry about it, the problem is too minor

natemaia commented 9 months ago

@TAforever Can you post your polybar config and dkrc (if used for starting polybar)?

If I can get some idea of what and where it's happening then I can do a lot more but right now it's a crap shoot and I don't want to mess around with hacky solutions unless absolutely necessary.

natemaia commented 9 months ago

A video of it would be helpful though I'm not sure how possible that is for you.

natemaia commented 9 months ago

I suppose a better way of doing this would be: can you run the default bar with polybar and does it still happen?

TAforever commented 9 months ago

Yes, with the default config the problem is reproduced, but I repeat once again: I think that you should not worry about this, because the problem is too minor, it only happens when loading and lasts a split second

natemaia commented 9 months ago

okie

TAforever commented 8 months ago

Today I noticed that polybar no longer blinks when it appears. Thanks for the fix

natemaia commented 8 months ago

Great to hear