search

natemcmaster / DotNetCorePlugins

.NET Core library for dynamically loading code
Apache License 2.0
1.6k stars 228 forks source link

Target dotnetcore3.1 #112

Closed iron9light closed 4 years ago

iron9light commented 4 years ago

Target dotnetcore 3.1 since it's LTS version. And it will be better if it supports Nullable Reference.

natemcmaster commented 4 years ago

Other than LTS designation, is there a reason to upgrade?

Also, this library supports nullable reference types already :) https://github.com/natemcmaster/DotNetCorePlugins/blob/e5d74ec3f35c70dc2618f6d38615de356485ccdd/Directory.Build.props#L22

iron9light commented 4 years ago

No other reason for me. I just upgraded all my projects from dotnetcore 3.0 -> 3.1. I think all dotnetcore 3.0 projects should upgrade to 3.1. 3.0 is more like a beta/RC.

natemcmaster commented 4 years ago

Ok, thanks for clarifying.

I'm planning to leave this library targeting netcoreapp3.0 and netcoreapp2.0 until there is a need for a higher target framework version. (For example, earlier versions of this library only had netcoreapp2.0, but I added 3.0 to support unloadability and hot reload.) It's my opinion that libraries should use the lowest target framework possible. This maximizes the number of end users who can consume this library without forcing them to upgrade to a new version of .NET Core.

If you find a reason, other than the LTS designation, that the upgrade is needed, let me know.

iron9light commented 4 years ago

make sense.