search

natemcmaster / DotNetCorePlugins

.NET Core library for dynamically loading code
Apache License 2.0
1.61k stars 227 forks source link

load pdb file if available for linenumbers in stacktrace #204

Closed sf8321 closed 3 years ago

sf8321 commented 3 years ago

if we want linenumbers in the stacktrace of a exception/Environment.StackTrace or StackTrace,GetFrame,... we have load the pdb files

changed method DotNetCorePlugins\src\Plugins\Loader\ManagedLoadContext.cs LoadAssemblyFromFilePath:187

sf8321 commented 3 years ago

i am ready. but i do not known what todo about the whitespace problem.

codecov[bot] commented 3 years ago

Codecov Report

Merging #204 (c811373) into main (11cdc4d) will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   82.75%   82.87%   +0.11%     
==========================================
  Files          15       15              
  Lines         574      578       +4     
==========================================
+ Hits          475      479       +4     
  Misses         99       99
Impacted Files Coverage Δ
src/Plugins/Loader/ManagedLoadContext.cs 79.35% <100.00%> (+0.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11cdc4d...c811373. Read the comment docs.

sf8321 commented 3 years ago

Ok i think pull request is ready

natemcmaster commented 3 years ago

Thanks!