search

natemcmaster / LettuceEncrypt

Free, automatic HTTPS certificate generation for ASP.NET Core web apps
https://nuget.org/packages/LettuceEncrypt
Apache License 2.0
1.59k stars 154 forks source link

LettuceEncryptKestrelHttpsOptionsExtensions.cs missing in NuGet package build version 1.0.1 and 1.0.0 #165

Closed MentalAllergen closed 3 years ago

MentalAllergen commented 3 years ago

Describe the bug The 1.0.1 and 1.0.0. versions of the NuGet packages seem to be build from source code which doesn't include the LettuceEncryptKestrelHttpsOptionsExtensions.cs with the HttpConnectionAdapterOptions extension method as showcased by this link which is available on the NuGet Gallery of the package.

To Reproduce Steps to reproduce the behavior:

  1. Using the 1.0.1 or 1.0.0 version of the package
  2. Try to build a clean app with a call to .UseKestrel() and .UseLettuceEncrypt(IServiceProvider)
  3. Build fails with compiler arguing that the requested extension method does not exist

The workaround I've used is to install any of the two pre-release version available on NuGet as they have the file with the extension method present in their source code. For anyone stumbling on this and wondering how to install pre-release versions of packages using NuGet, read this.

I'm happy to stay on the pre-relase package verision, but I think many will hit this hurdle when they try using this package and the workaround isn't all that intuitive.

natemcmaster commented 3 years ago

Yes, that will get fixed in the 1.1.0 release. In the meantime, use the pre-release versions from nuget.org.

densen2014 commented 3 years ago

use the pre-release versions from nuget.org

natemcmaster commented 3 years ago

1.1.0 is released now, by the way.