search

natemcmaster / LettuceEncrypt

Free, automatic HTTPS certificate generation for ASP.NET Core web apps
https://nuget.org/packages/LettuceEncrypt
Apache License 2.0
1.59k stars 154 forks source link

Fix sample 'Web' - make IAccountStore optional dependency #132 #145 #191

Closed huesie closed 3 years ago

huesie commented 3 years ago

Getting the sample fully running is tricky as it needs public forwarded port/ngrok but it's still off putting for new users to hit a DI error on sample 'Web'. I note that AcmeCertificateFactory.cs already has a fallback for IAccountStore being null - I propose this 1-line PR that makes IAccountStore optional and closes #132 and #145. It changes AcmeCertificateFactory.cs ctor parameter order so this could be considered a breaking change but that class is internal.

huesie commented 3 years ago

Thanks @Fydar - it's still showing that this needs approval - are you ok to approve and merge this, @natemcmaster ?

codecov[bot] commented 3 years ago

Codecov Report

Merging #191 (8d9c4ae) into main (84858b1) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   47.16%   47.16%           
=======================================
  Files          41       41           
  Lines        1060     1060           
=======================================
  Hits          500      500           
  Misses        560      560
Impacted Files Coverage Δ
.../LettuceEncrypt/Internal/AcmeCertificateFactory.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5960f96...8d9c4ae. Read the comment docs.