search

natemcmaster / LettuceEncrypt

Free, automatic HTTPS certificate generation for ASP.NET Core web apps
https://nuget.org/packages/LettuceEncrypt
Apache License 2.0
1.55k stars 153 forks source link

Added X1 Root certificate #230

Closed MarkCiliaVincenti closed 1 year ago

MarkCiliaVincenti commented 2 years ago

Added X1 Root certificate to tackle the issue mentioned in https://github.com/natemcmaster/LettuceEncrypt/issues/229

natemcmaster commented 2 years ago

Hey there, thanks for proposing a change. I don't know enough about this issue, nor do I see evidence of enough validation and testing to accept this change. As an alternative solution to #229, I would be okay if we could add some kind of extensibility point into the library so you can manipulate the certificate in your own applications. This would be preferable to making a change in this library code for now. I haven't run into the issues you are seeing with SSL certs, but if it is a problem in Certes itself, I would rather have Certes issue an update than accept this workaround.

MarkCiliaVincenti commented 2 years ago

Hey there, thanks for proposing a change. I don't know enough about this issue, nor do I see evidence of enough validation and testing to accept this change. As an alternative solution to #229, I would be okay if we could add some kind of extensibility point into the library so you can manipulate the certificate in your own applications. This would be preferable to making a change in this library code for now. I haven't run into the issues you are seeing with SSL certs, but if it is a problem in Certes itself, I would rather have Certes issue an update than accept this workaround.

Check the certificates at any SSL checker, such as https://www.sslshopper.com/ssl-checker.html

I created https://github.com/MarkCiliaVincenti/TlsCertificateLoader to deal with these issues and I think you could easily change LettuceEncrypt to make use of this package.

kamyker commented 1 year ago

I wasn't able to get Let's Encrypt staging certificate without X1. Prod worked fine.