search

natemcmaster / LettuceEncrypt

Free, automatic HTTPS certificate generation for ASP.NET Core web apps
https://nuget.org/packages/LettuceEncrypt
Apache License 2.0
1.59k stars 154 forks source link

Support certificate-per-domain #236

Closed zakeryooo closed 1 year ago

zakeryooo commented 2 years ago

Hi,

I'm using LettuceEncrypt in a YARP project, the reverse proxy sends requests from https://domain1.com and https://domain2.com to separate web apps each using their own kestrel instances (localhost:5001, localhost:5005).

Everything is working OK, but LettuceEncrypt is generating a single SSL certificate which covers both domains and instead I'm wanting it to generate a separate certificate for each domain, it's configured like this at the moment:

"DomainNames": [ "domain1.com", "domain2.com" ],

Is there a way to generate a certificate-per-domain instead of a single certificate for all domains?

Thanks

natemcmaster commented 2 years ago

This is not currently possible.

zakeryooo commented 2 years ago

Ok thanks, do you know if anyone else is working on this? I haven't had chance to look at the code yet be aware of how much work would be needed to add this, but if I get time to add it is it the sort of thing you'd accept a pull request for?

natemcmaster commented 2 years ago

I doubt anyone is working on this. The project is currently in maintenance mode (#189) so I'm not actively developing it, and there are aren't any other active contributors on this project. I'm not opposed to adding features, but even if someone else is implementing, it takes time for me to review, provide meaningful feedback, and then support the change for years to come.

I am not saying this to discourage you. I'm open to having other active contributors join this project who can pick up feature work and also provide support and bug fixes, but so long as I'm the only maintainer, I don't plan to accept new features.

benschop-it commented 2 years ago

I am also very much interested in certificate-per-domain functionality, and I'd be happy to work with someone (zakeryooo?) on this.

natemcmaster commented 2 years ago

Marking as help wanted. Let me know if you're interested in contributing this feature request.

benschop-it commented 2 years ago

I have implemented this feature in my fork at https://github.com/benschop-it/LettuceEncrypt-Benschop-IT. This makes it possible to create a certificate per set of domains. Some extra tests still need to be added. Feel free to comment.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please comment if you believe this should remain open, otherwise it will be closed in 14 days. Thank you for your contributions to this project.

github-actions[bot] commented 1 year ago

Closing due to inactivity. If you are looking at this issue in the future and think it should be reopened, please make a commented here and mention natemcmaster so he sees the notification.