natemcmaster / LettuceEncrypt

Free, automatic HTTPS certificate generation for ASP.NET Core web apps
https://nuget.org/packages/LettuceEncrypt
Apache License 2.0
1.55k stars 152 forks source link

feature: add API for configuring EAB (External Account Binding) credentials #252

Closed bugproof closed 2 years ago

bugproof commented 2 years ago

Closes #251

This is required for ZeroSSL and other certificate authorities that require providing EAB credentials.

codecov[bot] commented 2 years ago

Codecov Report

Merging #252 (1e3c393) into main (65f0ce7) will decrease coverage by 0.24%. The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   46.48%   46.23%   -0.25%     
==========================================
  Files          44       45       +1     
  Lines        1108     1116       +8     
==========================================
+ Hits          515      516       +1     
- Misses        593      600       +7     
Impacted Files Coverage Δ
src/LettuceEncrypt/Acme/EabCredentials.cs 0.00% <0.00%> (ø)
src/LettuceEncrypt/Internal/AcmeClient.cs 0.00% <0.00%> (ø)
src/LettuceEncrypt/Internal/AcmeClientFactory.cs 0.00% <0.00%> (ø)
src/LettuceEncrypt/LettuceEncryptOptions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9f0d3f...1e3c393. Read the comment docs.