search

natemcmaster / LettuceEncrypt

Free, automatic HTTPS certificate generation for ASP.NET Core web apps
https://nuget.org/packages/LettuceEncrypt
Apache License 2.0
1.55k stars 152 forks source link

Add Support for Google Certificates #263

Closed RehanSaeed closed 5 months ago

RehanSaeed commented 1 year ago

Google added support for ACME certificates, it would be nice to add support to this library:

https://scotthelme.co.uk/another-free-ca-to-use-via-acme/

Blackclaws commented 1 year ago

If google certificates implement the standard ACME protocol then you could just implement a custom: ICertificateAuthorityConfiguration and add it to the service collection after adding LettuceEncrypt to overwrite the default:

services.TryAddSingleton<ICertificateAuthorityConfiguration, DefaultCertificateAuthorityConfiguration>();
Mafii commented 1 year ago

@RehanSaeed did you ever try this out? I've spent some time trying to use the current Let's Encrypt staging server, and figured out that the root certificate has to be passed to certes as it is not embedded as resource (the old staging certificate is).

I'm asking because to my knowledge using google's acme server should cause the same problem to appear. So your feedback would be valuable to #279!

RehanSaeed commented 1 year ago

Sorry @Mafii, I haven't tried it.

natemcmaster commented 1 year ago

I've just merged https://github.com/natemcmaster/LettuceEncrypt/pull/279. Can you take a look at this and see if it solves your problem?

In addition, I am marking this as help wanted. I would be open to adding some code which will pre-configure the ACME endpoints and issuers to make Google's ACME server work. I don't know what the right settings are myself or how to test it, so I would require help to complete this feature.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please comment if you believe this should remain open, otherwise it will be closed in 14 days. Thank you for your contributions to this project.

github-actions[bot] commented 5 months ago

Closing due to inactivity. If you are looking at this issue in the future and think it should be reopened, please make a commented here and mention natemcmaster so he sees the notification.