natemcmaster / LettuceEncrypt

Free, automatic HTTPS certificate generation for ASP.NET Core web apps
https://nuget.org/packages/LettuceEncrypt
Apache License 2.0
1.55k stars 152 forks source link

Add IssuerCertificates to ICertificateAuthorityConfiguration #281

Closed Mafii closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #281 (7538f5b) into main (140b238) will increase coverage by 2.98%. The diff coverage is 52.38%.

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   44.40%   47.38%   +2.98%     
==========================================
  Files          48       51       +3     
  Lines        1153     1167      +14     
==========================================
+ Hits          512      553      +41     
+ Misses        641      614      -27     
Impacted Files Coverage Δ
...ceEncrypt/Internal/PfxBuilder/PfxBuilderFactory.cs 0.00% <0.00%> (ø)
...ceEncrypt/Internal/PfxBuilder/PfxBuilderWrapper.cs 0.00% <0.00%> (ø)
src/LettuceEncrypt/LettuceEncryptOptions.cs 100.00% <ø> (ø)
.../LettuceEncrypt/Internal/AcmeCertificateFactory.cs 20.35% <69.23%> (+20.35%) :arrow_up:
...Encrypt/Acme/ICertificateAuthorityConfiguration.cs 100.00% <100.00%> (ø)
...crypt/LettuceEncryptServiceCollectionExtensions.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mafii commented 1 year ago

@natemcmaster I will come back to this once I find time, thanks for the feedback!

Mafii commented 1 year ago

@natemcmaster I understand if you have a lot going on, I'm not entitled to your time at all! If you find time however, and this just got lost in the noise, I'd appreciate a review/approval and release a lot :)

Mafii commented 1 year ago

No worries, and thanks!